search

feedhenry / fh-ios-sdk

FeedHenry iOS (Objective-C) SDK
http://feedhenry.org
Apache License 2.0
6 stars 16 forks source link

Module map #33

Closed cvasilak closed 8 years ago

cvasilak commented 9 years ago

Motivation: as described in FHMOBSDK-69, currently the fh-sdk lacks an umbrella header. Commonly, the name of the spec (in our case FH.h) is used but since it'a a concrete class we cannot utilised. Doing so though, the default behaviour of cocoapods-packager needed to be adjusted to support the module_map directive that cocoapods provides to support this scenario. Please check the PR we issued on cocoapods-packager for more information.

To test Since, cocoapods-packager hasn't be released with our change, we need first to install the 'master' version. Do so:

git clone https://github.com/CocoaPods/cocoapods-packager.git
cd cocoapods-packager
bundle install
bundle exec rake build
sudo gem install pkg/cocoapods-packager-1.1.1.gem

Once that is done, clone the repo and try to create a framework distribution:

pod package FH.podspec

open FH-2.2.8/ios/FH.framework/Modules/module.modulemap and notice that the correct umbrella header is honoured FeedHenry.h

You can also clone the fh-ios-sdk-blank up that uses that updated framework distribution and imports the umbrella header for further tests.

@corinnekrych @wei-lee mind to review?

[Note] To facilitate testing the podspec uses this priv branch, but once we are ready to merge it, we will change the pod spec's repo to point to the official one.

wei-lee commented 9 years ago

Reviewed. Looks good. You can go ahead with the merge.

matzew commented 9 years ago

Let's not merge until this is actually in CocoaPods :-)

matzew commented 9 years ago

according to @cvasilak it can be merged now :-) I was misunderstanding this :)

/cc @corinnekrych

matzew commented 9 years ago

It's up to @wei-lee :-)

cvasilak commented 9 years ago

as of yesterday cocoapods-packager has made a new release v1.2.0 that incorporates our change.

@corinnekrych when u can mind to review/merge and prepare a new framework release.

sheldongill commented 9 years ago

We can't see the description in that link as Jira for JBoss Developer refuses.

corinnekrych commented 8 years ago

Let's close this one for now.