search

feedhenry / fh-ios-sdk

FeedHenry iOS (Objective-C) SDK
http://feedhenry.org
Apache License 2.0
6 stars 16 forks source link

Carthage support #41

Closed rhodgkins closed 6 years ago

rhodgkins commented 9 years ago

Hi,

Would you mind if I added Carthage support to the Feedhenry iOS SDK?

Cheers,

Rich

wei-lee commented 9 years ago

@rhodgkins no, not at all. Feel free to add support for that.

rhodgkins commented 9 years ago

@wei-lee great thanks! Been looking into it and got it working but as you don't have Pods checked in the dependencies are missing when carthage pulls and builds. Is there a reason they're not checked in? :)

wei-lee commented 9 years ago

@rhodgkins I think we have the Pods dir checked into the repo at some point, but we didn't find it's useful and it significantly increases the size of the repo, and sometimes makes it difficult to see actual code changes when there are dependency updates. So we removed it from the repo.

Can you just run

pod install

to install the dependencies first?

rhodgkins commented 9 years ago

Unfortunately carthage doesn't give you that "hook" before compiling the library. I think I can get around it by have the framework target have dependencies based on carthage created frameworks instead and just have those single .framework files in. I shall have a play around :)

Nathan187 commented 7 years ago

any update on this. is there carthage support?

danielpassos commented 6 years ago

Hey @rhodgkins, @Nathan187

Just a heads up on this, I have create a taks for it. We are going to work on this one after finish all we need to support iOS 11

Keep in touch in https://issues.jboss.org/browse/FH-4316