search

feedhenry / fh-ios-sdk

FeedHenry iOS (Objective-C) SDK
http://feedhenry.org
Apache License 2.0
6 stars 16 forks source link

Add Meta Data to Datasets #42

Closed evanshortiss closed 9 years ago

evanshortiss commented 9 years ago

Currently adding meta data to datasets isn't possible despite it being a property of the dataset class. It's not included with the HTTP requests either. This PR adds both, but is untested since I was unable to compile due to libPods.a not being available even after pod install. Lack of experience with pods on my part is the issue.

evanshortiss commented 9 years ago

@conoro, @johnfriz any plans to merge this for a future release?

conoro commented 9 years ago

@johnfriz Should we pass to Corinne for evaluation?

corinnekrych commented 9 years ago

:eyes: @evanshortiss did you open and build the *.xcworkspace file or the .xcodeproj? After doing a pod install, open and work with generated workspace. Do you still face the issue?

evanshortiss commented 9 years ago

I believe that is the issue @corinnekrych. It was my first exposure to CocoaPods and I missed that, I since learned the error of my ways on another iOS endeavour!

I'll check as soon as I can and verify tests are passing. I haven't added any new ones although I understand that would be ideal. I do know @cianclarke has done some work in that regard.

evanshortiss commented 9 years ago

@corinnekrych unit tests are passing

wei-lee commented 9 years ago

LGTM. Going to merge this.

corinnekrych commented 9 years ago

+1 to merge

wei-lee commented 9 years ago

Merged in 223d159ee92fb8b34d67caeef0d40a14157d38e7

evanshortiss commented 9 years ago

Thanks guys.