Refactor saveAndNotify to not send SYNC_COMPLE_MESSAGE when failure e…

feedhenry / fh-ios-sdk

FeedHenry iOS (Objective-C) SDK

http://feedhenry.org

Apache License 2.0

6 stars 16 forks source link

Refactor saveAndNotify to not send SYNC_COMPLE_MESSAGE when failure e… #73

Closed corinnekrych closed 8 years ago

corinnekrych commented 8 years ago

…vent occurs @danielpassos @secondsun Do you mind reviewing that one. I also noticed that fh-android-sdk suffers the same bug. See how syncComplete is implemented (taking no notification message in param).

Whereas JS SDK and Windows SDK take a notification event in param. when it's a failure only the SYNC_FAILED is raised.

secondsun commented 8 years ago

@corinnekrych interesting... Do you have a JIRA we can track this with?

corinnekrych commented 8 years ago

@secondsun I think we missed the JIRA... So here we have one now: https://issues.jboss.org/browse/FH-2624 ;)

danielpassos commented 8 years ago

LGTM