search

feedhenry / fh-ios-sdk

FeedHenry iOS (Objective-C) SDK
http://feedhenry.org
Apache License 2.0
6 stars 16 forks source link

Add oauth token in fh.cloud as x-fh-sessiontoken header #74

Closed corinnekrych closed 8 years ago

corinnekrych commented 8 years ago

@secondsun @danielpassos In the case of oauth2 policyId (see set up here: https://github.com/feedhenry-templates/oauth-ios-app#set-up-google-provider) the sessionToken were not filled in with oauth token, as a result subsequent fh.cloud call does not have oauth token in x-fh-sessiontoken header.

Question: in fh-andrdoi-sdk does that line: https://github.com/feedhenry/fh-android-sdk/blob/master/fh-android-sdk/src/main/java/com/feedhenry/sdk/api/FHAuthRequest.java#L229-L231 also save the token in case of oauth2 policyId?

To test:

  1. use oauth-ios-app, in Podfile point to this PR branch
  2. authenticate with google
  3. do a cloud call, using a http snipper tools (like Charles) check x-fh-sessiontoken header is set.
secondsun commented 8 years ago

@corinnekrych in Android it doesn't save the policy ID, but the policy ID is hard coded into the application. https://github.com/feedhenry/fh-android-sdk/blob/master/fh-android-sdk/src/main/java/com/feedhenry/sdk/api/FHAuthRequest.java#L114

corinnekrych commented 8 years ago

@danielpassos Closing this PR as not needed. After @mmurphy explanation on the ticket. The issue was for auth and not oauth.