RHMAP-16646 Check if connection tags is disabled

feedhenry / fh-ios-sdk

FeedHenry iOS (Objective-C) SDK

http://feedhenry.org

Apache License 2.0

6 stars 16 forks source link

RHMAP-16646 Check if connection tags is disabled #80

Closed jcesarmobile closed 7 years ago

jcesarmobile commented 7 years ago

To test on helloworld-ios template use pod 'FH', :git => 'https://github.com/jcesarmobile/fh-ios-sdk', :branch => 'RHMAP-16646' And remove the button.hidden = YES; on the fh init failure block so cloud function can be called

coveralls commented 7 years ago

Coverage decreased (-0.1%) to 51.355% when pulling 999a043f4827a735541de8e37454209e4f6f1c1e on jcesarmobile:RHMAP-16646 into c1de9d6df85eefd52569ce41168df3921eadcaa9 on feedhenry:master.

coveralls commented 7 years ago

Coverage increased (+11.4%) to 62.842% when pulling 9bbc41c5fd7242f6fd4212dd090722ebbe06ba86 on jcesarmobile:RHMAP-16646 into c1de9d6df85eefd52569ce41168df3921eadcaa9 on feedhenry:master.

coveralls commented 7 years ago

Coverage increased (+11.4%) to 62.842% when pulling 6e4e2d25df0a10f51a5fdbb4a21c3cac483e53c4 on jcesarmobile:RHMAP-16646 into c1de9d6df85eefd52569ce41168df3921eadcaa9 on feedhenry:master.

jcesarmobile commented 7 years ago

@danielpassos I've created another PR solving the problem in a different way https://github.com/feedhenry/fh-ios-sdk/pull/81

Let me know which one do you like most (if any)

danielpassos commented 7 years ago

👍