feedhenry / fh-ios-swift-sdk

FeedHenry iOS (Swift) SDK
http://feedhenry.org
4 stars 17 forks source link

xCode 8.3 build error #41

Closed misanche closed 7 years ago

misanche commented 7 years ago

Hi,

I have been trying to build the project without success.

Always getting: module.modulemap Redefinition of module 'FeedHenry'

I have modified the name of the module.modulemap for FeedHenry.modulemap and now compiles correctly.

I haven't checked with previous version of xCode, but could be helpful to test for next release.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 62.652% when pulling 9d9e376e910cd5b7f4b34f771041178cce378fcc on misanche:master into 3f6e6e4752f73f8162ad2d60d7a1d7983beb8245 on feedhenry:master.

pb82 commented 7 years ago

Merging this as @jhellar has already verified that the fix works with xcode 8.1 (current build farm) and 8.3.2 (latest)

rafaeltuelho commented 7 years ago

this also happens with fh-ios-sdk (objectve-c) I raised a JIRA on https://issues.jboss.org/browse/FH-4137