feedhenry / fh-ios-swift-sdk

FeedHenry iOS (Swift) SDK

http://feedhenry.org

4 stars 17 forks source link

feat: change the name of initEnv to initWithCustomConfigName, add pull request template:RHMAP-22053 #57

Closed austincunningham closed 5 years ago

austincunningham commented 5 years ago

What

Change the name of initEnv to initChangeConfigFileName, add pull request template, Add more information on how said method could be used

Why

Clarification for support on how said method would be supported going forward

How

edit the method name and comment

Verification Steps

No functionality change with method name change

Checklist:

[ ] Code has been tested locally by PR requester
[ ] Changes have been successfully verified by Feedhenry team member

codecov[bot] commented 5 years ago

Codecov Report

Merging #57 into master will not change coverage. The diff coverage is 0%.

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   74.78%   74.78%           
=======================================
  Files          30       30           
  Lines        2427     2427           
=======================================
  Hits         1815     1815           
  Misses        612      612

Impacted Files	Coverage Δ
FeedHenry/FH.swift	`31.91% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3005a76...6987dbd. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #57 into master will not change coverage. The diff coverage is 0%.

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   74.78%   74.78%           
=======================================
  Files          30       30           
  Lines        2427     2427           
=======================================
  Hits         1815     1815           
  Misses        612      612

Impacted Files	Coverage Δ
FeedHenry/FH.swift	`31.91% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3005a76...5776a49. Read the comment docs.