search

feedhenry / fh-sync

Node.js implementation of the FeedHenry Data Synchronisation Server. To be used in conjunction with the FeedHenry Data Synchronisation Client.
http://feedhenry.org
Apache License 2.0
5 stars 17 forks source link

Add default callback for dropTTLIndex #29

Closed aidenkeating closed 7 years ago

aidenkeating commented 7 years ago

There were cases where the callback would not be invoked when checking whether to drop the ttl index. This adds in a default.

aidenkeating commented 7 years ago

@wtrocki @david-martin Would you mind taking a look? I think this fixes the issue we are seeing. Not sure whether this should be true or false by default. My body is too full of sugar from Dr Pepper to think this through rationally.

wtrocki commented 7 years ago

Reviewed and verified that. After applying this change I no longer see any issues.

aidenkeating commented 7 years ago

@david-martin Thanks for the review, those suggestions made sense. Updated based on review.

david-martin commented 7 years ago

@aidenkeating @wtrocki published fh-sync@1.0.7

wtrocki commented 7 years ago

@david-martin Do you think it's best to also bump fh-mbaas-api? Created PR (linked above)