feedhenry / fh-sync

Node.js implementation of the FeedHenry Data Synchronisation Server. To be used in conjunction with the FeedHenry Data Synchronisation Client.
http://feedhenry.org
Apache License 2.0
5 stars 17 forks source link

🐛 a few optimisations to improve performance of the sync request #30

Closed wei-lee closed 7 years ago

wei-lee commented 7 years ago

We discovered that when some clients have large number of acks in the requests, the ack queue can be built up quite quickly and that will slow everything down of the system.

This change add the following optimisations:

  1. adding a flag to allow skip waiting for the ack insertion to be completed in the sync requests.
  2. allow developers to specify the maximum number of acks of each request to process

ping @david-martin @wtrocki