search

feedhenry / fh-sync

Node.js implementation of the FeedHenry Data Synchronisation Server. To be used in conjunction with the FeedHenry Data Synchronisation Client.
http://feedhenry.org
Apache License 2.0
5 stars 17 forks source link

Override cuid #31

Closed wei-lee closed 7 years ago

wei-lee commented 7 years ago

This PR will add a new configuration to allow developers override the CUID field.

In one customer's app, we have observed some devices have duplicated CUIDs in the requests. We are still investigating the root cause. But to unblock the customer, we can provide a cuidGenerator function to allow overrides to be provided.

Ping @wtrocki @aidenkeating for review

wtrocki commented 7 years ago

@wei-lee Added some comments. Let me know what you think. I can aprove and verify this changes for you.

wtrocki commented 7 years ago

Verified changes using community version. Going to verify them again once updates will be available

wei-lee commented 7 years ago

@wtrocki @aidenkeating comments addressed

wei-lee commented 7 years ago

published to npm