search

feedhenry / fh-sync

Node.js implementation of the FeedHenry Data Synchronisation Server. To be used in conjunction with the FeedHenry Data Synchronisation Client.
http://feedhenry.org
Apache License 2.0
5 stars 17 forks source link

sync.connect hangs #34

Closed evanshortiss closed 7 years ago

evanshortiss commented 7 years ago

Just a heads up. In release 1.0.5 there's a clause like so in mongodbQueue.js that causes sync startup to fail due to a missing else:

if (!existingIndex) {
  return callback(null, false);
} else if (existingIndex.expireAfterSeconds !== self.queueOptions.ttl) {
  return callback(null, true);
}

Not sure what the else should be here so flagging for input @wtrocki. The master branch does not have this so I assume it's on some other branch?

evanshortiss commented 7 years ago

I worked around it by deleting the sync queue and other collections in MongoDB for now.

wtrocki commented 7 years ago

See: https://github.com/feedhenry/fh-sync/pull/29/files

wtrocki commented 7 years ago

@evanshortiss Thanks for reporting bug. I see this change on master. 1.0.5 was broken. It was fixed in 1.0.7, but maybe there is another case I'm missing.

evanshortiss commented 7 years ago

@wtrocki nice, it was just the specific release I had so. Looks good to close this!