feedhenry / fh-sync

Node.js implementation of the FeedHenry Data Synchronisation Server. To be used in conjunction with the FeedHenry Data Synchronisation Client.
http://feedhenry.org
Apache License 2.0
5 stars 17 forks source link

RHMAP-21645 - Upgrade mongodb to 2.2.33 ( minor version ) #51

Closed camilamacedo86 closed 6 years ago

camilamacedo86 commented 6 years ago

Jira link(s)

https://issues.jboss.org/browse/RHMAP-21645

What

Upgrade mogodb to 2.2.33 ( minor version bumped )

Why

How

Verification Steps

Check if the CI will finish with success it did not have breakages

Checklist:

grdryn commented 6 years ago

@camilamacedo86 @damienomurchu Note that in the newer versions of the MongoDB driver that's updated here, if it's connecting to a replica set, the replicaset=<replicaset name> parameter needs to be specified on the connection string. We've just hit this in https://github.com/fheng/fh-supercore/pull/1146, so just thought I'd highlight it here. I'm not sure if it affects this project or not, since I don't know how this one works really.

camilamacedo86 commented 6 years ago

Hi @grdryn I made a comment in the JIRA which follows.

[~grdryn] could it not be an issue related to the changes performed in the script related to this setup?

Also, if it is regarding the lib could you try the version 2.2.33 of this lib? Shows that a bug related to it was solved here : https://github.com/mongodb/node-mongodb-native/commit/9a7073243de645f0d4e787beb4008fe78bc039dc . And the version 2.1.13 as the lower ones has CVEs. See https://github.com/mongodb/node-mongodb-native/compare/V2.2.13...v2.2.33

camilamacedo86 commented 6 years ago

Added a comment in https://issues.jboss.org/browse/RHMAP-21743 for we check it and if be required revert this one. Also, could you link there the JIRA that you will create regards the replicaset param?