Proposed restructuring for removal of fh-mbaas-express issue #2

feedhenry / fh-sync

Node.js implementation of the FeedHenry Data Synchronisation Server. To be used in conjunction with the FeedHenry Data Synchronisation Client.

http://feedhenry.org

Apache License 2.0

5 stars 17 forks source link

Proposed restructuring for removal of fh-mbaas-express issue #2 #6

Closed david-martin closed 7 years ago

david-martin commented 7 years ago

Issue #2

Changes:

Rename from fh-sync-cloud to just fh-sync (having the 'cloud' in the name makes it sound less standalone)
Remove the 'sync' sub-folder in lib, test & integration folders
Remove the fh-mbaas-express coupling
Remove all non sync code & tests
Get all unit & integration tests working via npm test
Add a sample server usage of the sync server example/server.js
Reset the README.md file to start with standalone sync usage steps
Remove unused dependencies from package.json that were carried over from fh-mbaas-api

david-martin commented 7 years ago

@wtrocki @aidenkeating @wei-lee Can you review these changes (they are quiet verbose, so i highlighted the changes in the description). This PR is aimed at completely decoupling fh-sync from any ties with fh-mbaas-* or RHMAP. Through this decoupling, it should be possible to drop it into fh-mbaas-api as a required module instead.

fyi, i published a placeholder package to https://www.npmjs.com/package/fh-sync until we have a viable first release

david-martin commented 7 years ago

@wtrocki thanks for merging. I've enabled the travis build for PRs now. I've added you and some others to the https://www.npmjs.com/package/fh-sync package on npm too. Feel free to add any other collaborators I've missed