search

feedhenry / mcp-standalone

Standalone version of the mobile-control-panel.
http://feedhenry.org
Apache License 2.0
13 stars 21 forks source link

[Installer] MCP Installation fails if grunt and bower are not globally installed #124

Closed johnfriz closed 6 years ago

johnfriz commented 6 years ago

When running the following task:

TASK [mcp-ui-extension-setup : install dist requirements] **

the following error is displayed

fatal: [localhost]: FAILED! => {"changed": true, "cmd": "cd /Users/jfrizell/go/src/github.com/feedhenry/mcp-standalone/installer/../ui && npm i && bower install && grunt build", "delta": "0:00:14.379960", "end": "2017-10-03 14:24:32.541219", "failed": true, "rc": 127, "start": "2017-10-03 14:24:18.161259", "stderr": "/bin/sh: bower: command not found", "stdout": "grunt-contrib-uglify@3.1.0 node_modules/grunt-contrib-uglify\n├── uri-path@1.0.0\n├── chalk@1.1.3 (supports-color@2.0.0, ansi-styles@2.2.1, escape-string-regexp@1.0.5, has-ansi@2.0.0, strip-ansi@3.0.1)\n├── uglify-es@3.1.3 (commander@2.11.0, source-map@0.5.7)\n└── maxmin@1.1.0 (figures@1.7.0, gzip-size@1.0.0, pretty-bytes@1.0.4)", "stdout_lines": ["grunt-contrib-uglify@3.1.0 node_modules/grunt-contrib-uglify", "├── uri-path@1.0.0", "├── chalk@1.1.3 (supports-color@2.0.0, ansi-styles@2.2.1, escape-string-regexp@1.0.5, has-ansi@2.0.0, strip-ansi@3.0.1)", "├── uglify-es@3.1.3 (commander@2.11.0, source-map@0.5.7)", "└── maxmin@1.1.0 (figures@1.7.0, gzip-size@1.0.0, pretty-bytes@1.0.4)"], "warnings": []}
    to retry, use: --limit @/Users/jfrizell/go/src/github.com/feedhenry/mcp-standalone/installer/playbook.retry

Taking the command and running it locally gives a meaningful error regarding grunt and bower if they are not installed globally...

$ cd /Users/jfrizell/go/src/github.com/feedhenry/mcp-standalone/installer/../ui && npm i && bower install && grunt build
grunt-contrib-uglify@3.1.0 node_modules/grunt-contrib-uglify
├── uri-path@1.0.0
├── chalk@1.1.3 (ansi-styles@2.2.1, supports-color@2.0.0, escape-string-regexp@1.0.5, strip-ansi@3.0.1, has-ansi@2.0.0)
├── uglify-es@3.1.3 (commander@2.11.0, source-map@0.5.7)
└── maxmin@1.1.0 (figures@1.7.0, gzip-size@1.0.0, pretty-bytes@1.0.4)
-bash: bower: command not found
evanshortiss commented 6 years ago

Looks like this was fixed a few days back. @david-martin on point!

david-martin commented 6 years ago

Fixed in https://github.com/feedhenry/mcp-standalone/pull/129/commits/fdcd510dc451bf43b8152f1350975554e5aba8fc#diff-d1174a4eb2f0863c385bedc5c1c1777e