search

feedhenry / mcp-standalone

Standalone version of the mobile-control-panel.
http://feedhenry.org
Apache License 2.0
13 stars 21 forks source link

local setup instructions won't work with when docker hub password contains exclamation "!" #202

Closed pwright closed 6 years ago

pwright commented 6 years ago

should we warn users to set dockerhub password with only alphanum characters?

maleck13 commented 6 years ago

No this seems like a bug

aidenkeating commented 6 years ago

@finp @maleck13 I can't seem to reproduce this, changed my password temporarily but everything worked fine. Will take a closer look tomorrow.

aidenkeating commented 6 years ago

@finp Thanks for your help on tracking this down.

Sounds like you were referring to this section (https://github.com/feedhenry/mcp-standalone/blob/master/docs/walkthroughs/local-setup.adoc#useful-bash-function) and using special characters here.

This issue doesn't occur when using the installer/install.sh script which we now recommend in the local setup doc. You can also use that bash function but escape the special characters.

Are you happy for this to be closed off?

pwright commented 6 years ago

@aidenkeating I'm happy! close it!