Closed sedroche closed 7 years ago
@sedroche Reviewing now & giving it a run through locally.
1 minor thing so far. Seeing an overflow/sizing issue with the service integration button
@sedroche approving & merging after local run through. I'm reading through the styleguide in more detail, but in general its a :+1: from me. Would be good to link to the styleguide in the local development part of the docs. re: the button issue, I won't let that hold up the merge. I can create an issue if you like fyi, my chrome version is Version 58.0.3029.110 (64-bit)
This style guide is being used as a reference for architecture and styleguide https://github.com/toddmotto/angularjs-styleguide
It outlines where we want to move to in terms of directory layout and component structure.
Main points:
@david-martin First part of grouping our components by feature. This is a more scalable structure for the project than the current separation by type. This initial PR should cover the main functionality so far but more features/components will probably fall out as the main views are turned into component trees. Components shared amongst features are going into the shared directory.
This PR incorporates: