search

feedhenry / mcp-standalone

Standalone version of the mobile-control-panel.
http://feedhenry.org
Apache License 2.0
13 stars 21 forks source link

Installer prereq checks #209

Closed aidenkeating closed 6 years ago

aidenkeating commented 6 years ago

@david-martin @jasonmadigan Would you mind taking a look?

jasonmadigan commented 6 years ago

@aidenkeating will give this a spin on a fresh fedora vm to see how I get on.

david-martin commented 6 years ago

@aidenkeating This gets my vote :+1: I tried it locally and works great! However, I have been installing/cleaning many times, so my system meets the pre-reqs. We'll have to fix/adapt as cases come through where the pre-reqs don't pick up on some things.

The only thing I'll suggest is updating the local-setup guide to say to run this script instead. Sound reasonable?

EDIT: @aidenkeating nevermind :) You're 2 steps ahead of me on the readme update. Note the conflict on the face-to-face.md file as I merged a change recently https://github.com/feedhenry/mcp-standalone/pull/212. I'll leave it to your judgement if you want to keep that change (i.e. link to local-setup.md) or leave the call to installer.sh.

jasonmadigan commented 6 years ago

@aidenkeating one miss: npm/node check

aidenkeating commented 6 years ago

@david-martin I've made a small update to the f2f doc to say to use the 0.0.6 tag when prompted. Other than that everything is linked to the local setup doc. Also added a check for NPM. I think we're ready to merge?