feedhenry / mcp-standalone

Standalone version of the mobile-control-panel.
http://feedhenry.org
Apache License 2.0
13 stars 21 forks source link

[WIP] Use previous oc dir for new oc #222

Closed aidenkeating closed 6 years ago

aidenkeating commented 6 years ago

@maleck13 Would you mind taking a look?

There are two main changes here. One in the interactive-y installer/install.sh script that will ask where you want to install the new oc binary. If there was a previous oc then it will default to that directory. It knows that will definitely cause the correct binary to be executed when oc is called. So the flow goes something like this:

The second change is in the Ansible installer, which just performs a basic check and bails out with an error message if oc is not the correct version.

There is also a PR up at (https://github.com/andrewrothstein/ansible-openshift-origin-client-tools) to resolve another case where a new oc won't be installed by the Ansible installer under certain circumstances.

I'll leave this open until that is merged and make the needed changes here after it's merged.

This resolves #221

maleck13 commented 6 years ago

👍