Use tutors ts - Githubissues

feedhenry / student-help-guide

Help Guide for Student Interns in FeedHenry

http://feedhenry.org/student-help-guide/

2 stars 8 forks source link

Use tutors ts #53

Closed laurafitzgerald closed 5 years ago

laurafitzgerald commented 5 years ago

What Update to build scripts and instructions to use tutors-ts to build the site Build and push related changes

Why https://github.com/feedhenry/student-help-guide/issues/52

Verification

run the build script.
The build should occur with no changes as these are pushed
The links from the left nav didn't work locally but they may work when the site is pushed so need to verify that afterwards. If they don't it's an issue with the package so can open an issue there.

@JameelB

laurafitzgerald commented 5 years ago

Merging and will review the navigation links once published.

damienomurchu commented 5 years ago

Agree, best to merge.

As seen, verifying that the site builds fine with the build.sh script, but the links from side navbar seem to be broken locally.

Let's see if this is an issue also with the published site. If so, my initial suspicion is this is an issue the way the url's are constructed as the fully qualified url works file:///home/damienmurphy/repos/student-help-guide/docs/topic02-schedule/index.html but the navbar url doesn't file:///topic02-schedule/book-schedule/index.html

laurafitzgerald commented 5 years ago

@damienomurchu yes there is an issue with the published site also. I agree it's to do with how the links are generated. I imagine this needs to be resolved in the tutor-ts package. I will dig in and see if there's an easy fix there.