search

feediron / ttrss_plugin-feediron

Evolution of ttrss_plugin-af_feedmod
https://discourse.tt-rss.org/t/plugin-update-feediron-v1-2-0/2018
MIT License
206 stars 34 forks source link

Add missing articleMarker declaration #152

Closed pR0Ps closed 4 years ago

pR0Ps commented 4 years ago

Was tipped off by a warning in the console:

strpos(): Non-string needles will be interpreted as strings in the future.
          Use an explicit chr() call to preserve the current behavior
pR0Ps commented 4 years ago

@dugite-code: For this change I basically just guessed based on the variable name and the fact that getMarker isn't called anywhere that this line was missed in a refactor or something. I don't know the code well enough to know if it's the correct fix or is going to break something else.

I've left this change running on my instance for a few days and it seems to be working (and the warning is gone) but I'd still maybe give this PR a bit of extra scrutiny.

EDIT: Found the commit that removed it. See https://github.com/feediron/ttrss_plugin-feediron/commit/c59f56d93439ca91740c5cc11965499704067854

dugite-code commented 4 years ago

Well that's been broken for a very long time! It looks like it's a bunch of legacy code and applies only to old versions of TT-RSS. The majority of recent code would break that compatibility anyway so I'll go through and remove this shortly.

Your change will cover the issue for now at least. Thanks for this!