search

feediron / ttrss_plugin-feediron

Evolution of ttrss_plugin-af_feedmod
https://discourse.tt-rss.org/t/plugin-update-feediron-v1-2-0/2018
MIT License
212 stars 34 forks source link

Readability issues #184

Closed benfishbus closed 2 years ago

benfishbus commented 2 years ago

Are the steps in the readme for installing readability current? I just followed them, only to be told: Package andreskrey/readability.php is abandoned, you should avoid using it. Use fivefilters/readability.php instead.

FWIW, I needed to install a bunch more php8 modules than indicated by the readme: docker compose exec app apk add php8-phar php8-openssl php8-iconv php8-curl php8-dom php8-xml php8-mbstring

dugite-code commented 2 years ago

I haven't updated the readability package on my install for a while, It's not been broken so I haven't fixed it. I'm using the docker container and I note it's now using php81-* for all these packages (excluding the phar package) https://git.tt-rss.org/fox/ttrss-docker-compose.git/tree/app/Dockerfile so that's probably the issue with needing to install these packages again (assuming you're on the docker container). sudo docker-compose exec app apk add php81-phar

dugite-code commented 2 years ago

Ok I found some time to look into things. Looks like I was a bit behind on updates myself

Looks like fivefilters have not done a proper release yet and the v2.1 release has the andreskrey namespace so it won't work, that said in php8.1 I'm seeing a few deprecation notices so still using andreskrey isn't ideal. Fox has forked the Readability.PHP and is currently maintaining it for use in af_readability So I have switched to this for now. I've also updated the instructions for PHP-8.1 If you're using the latest container you shouldn't have PHP version: 8.0.22