IngredientList bugs and reduce complexity update - Githubissues

feedme-swent-epfl / feedme-android

A repository for the CS-311 Software Enterprise class at EPFL.

1 stars 0 forks source link

IngredientList bugs and reduce complexity update #266

Closed FacerOfGod closed 3 months ago

FacerOfGod commented 3 months ago

Cleaning up the IngredientList file to match the requirements in term of code complexity and fix UI bugs

Complexity :

[x] Remove InputIngredientState system way to confusing to use
[x] Reduce cognitive complexity

Bug Fix :

[x] Quantity : if completely empty crashes the app
[x] Quantity : if modifed last you can not validate the ingredient
[x] Ingredient is considered as a valid ingredient in the database aka. green but should be red
[x] Ingredient is case sensitive, not a great user experience
[x] Generate button was clickable even if there was empty fields

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud