search

feedreader / pluto

pluto gems - planet feed reader and (static) website generator - auto-build web pages from published web feeds
Creative Commons Zero v1.0 Universal
192 stars 14 forks source link

Support the quiet command line arg #11

Closed harry-wood closed 6 years ago

harry-wood commented 6 years ago

Feed through the 'quiet' command line arg into an 'opts' boolean, but use it just to set the log level to 'warn'

This is tackling https://github.com/feedreader/pluto/issues/4 but...

TODO: use loggers instead puts everywhere

geraldb commented 6 years ago

@harry-wood Thanks for taking this on. Note: You're more than welcome if interested to join the feedreader github org(anization) so you can commit without pull requests etc If interested I can send you an invite via github (just let me know). Keep it up. Cheers.

harry-wood commented 6 years ago

Well I don't mind doing things the pull request way. I think I understand the code now, but it might be better to have you review my changes.

I'm going to look at changing all puts into 'logger' calls now if that makes sense to you. Then this 'quiet' mode will be more meaningful.

I wonder if I should've made quiet mode mean log level :error rather than :warn. Well we shall see how noisy it looks

geraldb commented 6 years ago

No worries. Any time just let me know. Again thanks for your effort. I'm always debugging when using pluto :-) thus, the missing quite mode. Keep it up. Thanks for changing the puts into logger calls. By the way the logger package / module is @ https://github.com/rubylibs/logutils/tree/master/logutils Cheers.