Import yarn.lock from package-lock.json

feedzai / brushable-histogram

A time histogram with a brushable preview of the whole dataset below it

Other

91 stars 9 forks source link

Import yarn.lock from package-lock.json #47

Closed lakhansamani closed 2 years ago

lakhansamani commented 4 years ago

This PR will help to fix the dependency versions if this package is installed via yarn.

Fixes #46

lfac-pt commented 4 years ago

Thank you for your pull request! There seems that some unit tests are failing with a missing module, could you take a look at those so we can merge this?

lakhansamani commented 4 years ago

@lfac-pt I tested locally! all test are passing with yarn test + npm run test

Also tested linting errors.

It would be great if you can share build error.

lfac-pt commented 4 years ago

It's failing on Travis https://travis-ci.com/github/feedzai/brushable-histogram/builds/158720201