feedzai / feedzai-openml-java

Implementations for Feedzai's OpenML APIs to allow for usage of machine learning models in the Java programming language.
https://www.feedzai.com
Apache License 2.0
2 stars 11 forks source link

Stop ignoring LightGBMBinaryClassificationModelTrainerTest #119

Closed ghost closed 2 years ago

ghost commented 2 years ago

The LightGBMBinaryClassificationModelTrainerTest shouldn't be ignored. For some reason it stopped failing so we'll simply erase the @Ignore annotation.

codecov[bot] commented 2 years ago

Codecov Report

Merging #119 (c6719b9) into master (cb6105c) will increase coverage by 0.60%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #119      +/-   ##
============================================
+ Coverage     79.30%   79.90%   +0.60%     
- Complexity      424      428       +4     
============================================
  Files            43       43              
  Lines          1498     1498              
  Branches        138      138              
============================================
+ Hits           1188     1197       +9     
+ Misses          231      224       -7     
+ Partials         79       77       -2     
Impacted Files Coverage Δ
...feedzai/openml/provider/lightgbm/LightGBMSWIG.java 79.68% <0.00%> (+1.56%) :arrow_up:
...tgbm/LightGBMBinaryClassificationModelTrainer.java 86.86% <0.00%> (+2.91%) :arrow_up:
...openml/provider/lightgbm/LightGBMModelCreator.java 87.23% <0.00%> (+3.19%) :arrow_up:
...er/lightgbm/LightGBMBinaryClassificationModel.java 60.86% <0.00%> (+4.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb6105c...c6719b9. Read the comment docs.

AlbertoEAF commented 2 years ago

Great news guys! Can we squash+merge already? :pray: @mlobofeedzai @antssilva96

This will already be useful for @AndreFCruz 's work