search

feedzai / feedzai-openml-java

Implementations for Feedzai's OpenML APIs to allow for usage of machine learning models in the Java programming language.
https://www.feedzai.com
Apache License 2.0
2 stars 11 forks source link

fix PULSEDEV-27633 openml-h2o: Adds more information in case of error #13

Closed MiguelSCruz closed 5 years ago

MiguelSCruz commented 5 years ago

An additional check was added to verify that the dataset that was written to disk is not empty, that would cause an error later inside the h2o code.

codecov[bot] commented 5 years ago

Codecov Report

Merging #13 into hf-1.0.X will increase coverage by 0.09%. The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             hf-1.0.X      #13      +/-   ##
==============================================
+ Coverage       79.49%   79.59%   +0.09%     
- Complexity        257      258       +1     
==============================================
  Files              27       27              
  Lines             839      843       +4     
  Branches           76       76              
==============================================
+ Hits              667      671       +4     
  Misses            130      130              
  Partials           42       42
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/feedzai/openml/h2o/server/H2OApp.java 85.22% <100%> (+0.7%) 29 <2> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4147fd2...febedc2. Read the comment docs.

nmldiegues commented 5 years ago

@pedrorijo91 can you help understand what happened with https://app.codacy.com/app/feedzai/feedzai-openml-java/pullRequest?prid=3586791 ? seems like it had an error on the analyser

pedrorijo91 commented 5 years ago

@pedrorijo91 can you help understand what happened with https://app.codacy.com/app/feedzai/feedzai-openml-java/pullRequest?prid=3586791 ? seems like it had an error on the analyser

the branch was not selected on codacy as a branch to analyse. it is now :)

JPDSousa commented 5 years ago

Nothing to add 👍

nmldiegues commented 5 years ago

Go to go IMO

I believe we are still waiting for the regression unit test, right @MiguelSCruz ? Also not to lower the coverage (as the codecov automation as already mentioned above)