Closed nmldiegues closed 5 years ago
Hey @nmldiegues,
Your changes look good to me!
Hey @nmldiegues,
Your changes look good to me!
Merging #2 into master will increase coverage by
0.73%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #2 +/- ##
============================================
+ Coverage 74.69% 75.43% +0.73%
- Complexity 216 220 +4
============================================
Files 22 22
Lines 739 753 +14
Branches 68 70 +2
============================================
+ Hits 552 568 +16
+ Misses 148 147 -1
+ Partials 39 38 -1
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...eedzai/openml/datarobot/DataRobotModelCreator.java | 91.3% <100%> (+1.56%) |
20 <1> (+3) |
:arrow_up: |
.../datarobot/ClassificationBinaryDataRobotModel.java | 69.44% <0%> (+2.77%) |
15% <0%> (+1%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update de54f7f...8221f0d. Read the comment docs.
Hey @nmldiegues,
Your changes look good to me!
@paulojrp can you re-review?
DataRobot is assuming "True", "False" whenever the target variable is boolean, regardless of is actual values.
This makes the provider flexible with respect to that.