search

feedzai / feedzai-openml-java

Implementations for Feedzai's OpenML APIs to allow for usage of machine learning models in the Java programming language.
https://www.feedzai.com
Apache License 2.0
2 stars 11 forks source link

LightGBM: Restore visibility modifiers. #29

Closed AlbertoEAF closed 4 years ago

AlbertoEAF commented 4 years ago

Some visibility modifiers were introduced with the port.

This restores the visibility modifiers where appropriate. This is mainly in the source code, but also includes one of the test schemas that was used for AutoML.

codecov[bot] commented 4 years ago

Codecov Report

Merging #29 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     77.69%   77.69%           
  Complexity      357      357           
=========================================
  Files            39       39           
  Lines          1318     1318           
  Branches        120      120           
=========================================
  Hits           1024     1024           
  Misses          228      228           
  Partials         66       66
Impacted Files Coverage Δ Complexity Δ
...enml/provider/lightgbm/LightGBMDescriptorUtil.java 96.96% <ø> (ø) 3.00 <0.00> (ø)
...eedzai/openml/provider/lightgbm/SWIGResources.java 73.33% <ø> (ø) 7.00 <0.00> (ø)
...i/openml/provider/lightgbm/SWIGTrainResources.java 83.78% <ø> (ø) 9.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d91ddff...245e549. Read the comment docs.

AlbertoEAF commented 4 years ago

@JPDSousa is there an explicit way to mark the default visibility modifier so Codacy does not complain? Must we change to protected?