Closed shengwangsw closed 4 years ago
Merging #32 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #32 +/- ##
=========================================
Coverage 77.69% 77.69%
Complexity 357 357
=========================================
Files 39 39
Lines 1318 1318
Branches 120 120
=========================================
Hits 1024 1024
Misses 228 228
Partials 66 66
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 99e8c82...3198693. Read the comment docs.
After set -e we need to define the workdir
@shenggwang it's good practice to elaborate a bit on the problem. I honestly don't know why you need to cd
after set -e
. You can leave a link here (e.g., a stack overflow question of someone with the same problem) or just elaborate on the problem using your own words.
The problem has to do with the directory, for the reason that I added cd
. Because by default it was working on \tmp
.
Thank you for your question, it makes me realise that it shouldn't be on script itself, instead on pom.xml :smile:
The problem has to do with the directory, for the reason that I added
cd
. Because by default it was working on\tmp
. Thank you for your question, it makes me realise that it shouldn't be on script itself, instead on pom.xml
Yes! set -e
is only a mode, doesn't affect directories, but the new solution is much better ;)
The problem has to do with the directory, for the reason that I added
cd
. Because by default it was working on\tmp
. Thank you for your question, it makes me realise that it shouldn't be on script itself, instead on pom.xmlYes!
set -e
is only a mode, doesn't affect directories, but the new solution is much better ;)
I don't know the reason, by debugging it with pwd, before set -e
it is in the correct directory, after that, the directory changed to /tmp
. It's weird, I don't know if this have to do with exec-maven-plugin
, but I didn't find anything related this issue.
After set -e we need to define the workdir