search

feedzai / feedzai-openml-java

Implementations for Feedzai's OpenML APIs to allow for usage of machine learning models in the Java programming language.
https://www.feedzai.com
Apache License 2.0
2 stars 11 forks source link

Text review #4

Closed krisztinaknagy closed 5 years ago

krisztinaknagy commented 5 years ago

Text review

TravisBuddy commented 5 years ago

Hey @krisztinaknagy,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: bdcbfd50-ec88-11e8-9232-d3c7ef027538
codecov[bot] commented 5 years ago

Codecov Report

Merging #4 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage     75.43%   75.43%           
  Complexity      220      220           
=========================================
  Files            22       22           
  Lines           753      753           
  Branches         70       70           
=========================================
  Hits            568      568           
  Misses          147      147           
  Partials         38       38

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7f92a9...2a19b2a. Read the comment docs.

TravisBuddy commented 5 years ago

Hey @krisztinaknagy,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 096d7380-ecaf-11e8-9232-d3c7ef027538
TravisBuddy commented 5 years ago

Hey @krisztinaknagy,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a845eb50-ecf4-11e8-9232-d3c7ef027538
paulojrp commented 5 years ago

this file is very similar to https://github.com/feedzai/feedzai-openml-java/blob/master/openml-h2o/README.md, it can be also improved (in a similar way).