search

feedzai / feedzai-openml-java

Implementations for Feedzai's OpenML APIs to allow for usage of machine learning models in the Java programming language.
https://www.feedzai.com
Apache License 2.0
2 stars 11 forks source link

Deploy lightgbmlib to nexus #43

Closed shengwangsw closed 4 years ago

shengwangsw commented 4 years ago

Change maven architecture and plugins to deploy lightgbmlib.

shengwangsw commented 4 years ago

Based on the build, it seemed that it failed to use libgomp.so.1.0.0 as null point. I believe that this file wasn't attached. Therefore, I will try first to see where libgomp.so.1.0.0 is generated, and why isn't us attaching it.

shengwangsw commented 4 years ago

I did a build on the master, and libgomp.so.1.0.0 indeed is generated and put into openml-lightgbm.jar. It is also included on openml-lightgbm/target/classes.

However, in this branch, it isn't included. Now I confirm that libgomp.so.1.0.0 is missing here. So let's fix this

shengwangsw commented 4 years ago

I think Codacy froze. I will make some refactoring on the code and a new commit to retrigger it again.

codecov[bot] commented 4 years ago

Codecov Report

Merging #43 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage     77.38%   77.38%           
  Complexity      355      355           
=========================================
  Files            39       39           
  Lines          1318     1318           
  Branches        120      120           
=========================================
  Hits           1020     1020           
  Misses          230      230           
  Partials         68       68
Impacted Files Coverage Δ Complexity Δ
...i/openml/provider/lightgbm/LightGBMAlgorithms.java 100.00% <ø> (ø) 3.00 <0.00> (?)
...er/lightgbm/LightGBMBinaryClassificationModel.java 57.14% <ø> (ø) 8.00 <0.00> (?)
...tgbm/LightGBMBinaryClassificationModelTrainer.java 87.17% <ø> (ø) 23.00 <0.00> (?)
...enml/provider/lightgbm/LightGBMDescriptorUtil.java 96.96% <ø> (ø) 3.00 <0.00> (?)
...ai/openml/provider/lightgbm/LightGBMException.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...i/openml/provider/lightgbm/LightGBMMLProvider.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...openml/provider/lightgbm/LightGBMModelCreator.java 82.35% <ø> (ø) 20.00 <0.00> (?)
...feedzai/openml/provider/lightgbm/LightGBMSWIG.java 70.96% <ø> (ø) 11.00 <0.00> (?)
...eedzai/openml/provider/lightgbm/LightGBMUtils.java 86.95% <ø> (ø) 4.00 <0.00> (?)
...eedzai/openml/provider/lightgbm/SWIGResources.java 73.33% <ø> (ø) 7.00 <0.00> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c6bd17...1aba91c. Read the comment docs.

shengwangsw commented 4 years ago

Why is this section hard-coded now? It was generated automatically. Must we now change it manually every time?

I don't know which parte you are saying. If you are saying make-lightgbm/build, it still is generating based on the script

shengwangsw commented 4 years ago

It still failing at deploy fase: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy (default-deploy) on project lightgbm-lib: Deployment failed: repository element was not specified in the POM inside distributionManagement element or in -DaltDeploymentRepository=id::layout::url parameter -> [Help 1] It seemed that I need to specify it on pom.xml inside distributionManagement

shengwangsw commented 4 years ago

Based on this experimental-tag, it is working. Nevertheless, I can't see anywhere about uploading lightgbm-lib:2.3.190. I think it is supposed, since we attached the libs on openml-lightgbm, i.e., now we don't need lightgbm-lib:2.3.190 since it is a uber.jar? @ptraca , can you confirm it please?