feedzai / feedzai-openml-java

Implementations for Feedzai's OpenML APIs to allow for usage of machine learning models in the Java programming language.
https://www.feedzai.com
Apache License 2.0
2 stars 11 forks source link

Skip deploy LightGBM lib #46

Closed shengwangsw closed 4 years ago

shengwangsw commented 4 years ago

There are always obstacles trying to deploy LightGBM lib as shown this time the following error:

[ERROR] Rule failure while trying to close staging repository with ID "comfeedzai-1227".
[ERROR] 
[ERROR] Nexus Staging Rules Failure Report
[ERROR] ==================================
[ERROR] 
[ERROR] Repository "comfeedzai-1227" failures
[ERROR]   Rule "javadoc-staging" failures
[ERROR]     * Missing: no javadoc jar found in folder '/com/feedzai/openml/lightgbm/lightgbm-lib/2.3.190'
[ERROR]   Rule "sources-staging" failures
[ERROR]     * Missing: no sources jar found in folder '/com/feedzai/openml/lightgbm/lightgbm-lib/2.3.190'
[ERROR] 
[ERROR] 
[ERROR] Cleaning up local stage directory after a Rule failure during close of staging repositories: [comfeedzai-1227]
[ERROR]  * Deleting context 24270bc3c6ea66.properties
[ERROR] Cleaning up remote stage repositories after a Rule failure during close of staging repositories: [comfeedzai-1227]
[ERROR]  * Dropping failed staging repository with ID "comfeedzai-1227" (Rule failure during close of staging repositories: [comfeedzai-1227]).

If skipNexusStagingDeployMojo works as claimed, it should skip deploying LightGBM lib, which we don't need it on the remote repository because it is included on the uber.jar


Final approach, we added maven-deploy-plugin, and skip the lightgbm-lib deploy. This indeed skipped, at least locally I tried mvn deploy and it successfully skipped deploy.

In addition, I renamed the folder name back to those that Paulo Traça had set in one of his commits.

codecov[bot] commented 4 years ago

Codecov Report

Merging #46 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage     77.38%   77.38%           
  Complexity      355      355           
=========================================
  Files            39       39           
  Lines          1318     1318           
  Branches        120      120           
=========================================
  Hits           1020     1020           
  Misses          230      230           
  Partials         68       68           
Impacted Files Coverage Δ Complexity Δ
...i/openml/provider/lightgbm/LightGBMAlgorithms.java 100.00% <ø> (ø) 3.00 <0.00> (?)
...er/lightgbm/LightGBMBinaryClassificationModel.java 57.14% <ø> (ø) 8.00 <0.00> (?)
...tgbm/LightGBMBinaryClassificationModelTrainer.java 87.17% <ø> (ø) 23.00 <0.00> (?)
...enml/provider/lightgbm/LightGBMDescriptorUtil.java 96.96% <ø> (ø) 3.00 <0.00> (?)
...ai/openml/provider/lightgbm/LightGBMException.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...i/openml/provider/lightgbm/LightGBMMLProvider.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...openml/provider/lightgbm/LightGBMModelCreator.java 82.35% <ø> (ø) 20.00 <0.00> (?)
...feedzai/openml/provider/lightgbm/LightGBMSWIG.java 70.96% <ø> (ø) 11.00 <0.00> (?)
...eedzai/openml/provider/lightgbm/LightGBMUtils.java 86.95% <ø> (ø) 4.00 <0.00> (?)
...eedzai/openml/provider/lightgbm/SWIGResources.java 73.33% <ø> (ø) 7.00 <0.00> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 657d030...5590f95. Read the comment docs.