feedzai / feedzai-openml-java

Implementations for Feedzai's OpenML APIs to allow for usage of machine learning models in the Java programming language.
https://www.feedzai.com
Apache License 2.0
2 stars 11 forks source link

Fix missing lightgbm dependencies on uber jar #51

Closed shengwangsw closed 4 years ago

shengwangsw commented 4 years ago

The commit ad56167 from MR #47 deploys lightgbm-lib as an independent jar to the remote repository. Which wasn't desired.

This commit amends the previous undesired behaviour by:

  1. including ligthgmb-lib in the uber jar;

  2. making lightgbm-lib non-transitive.

This way prevents to deploy to a remote repository.

codecov[bot] commented 4 years ago

Codecov Report

Merging #51 into master will increase coverage by 0.11%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #51      +/-   ##
============================================
+ Coverage     77.76%   77.88%   +0.11%     
- Complexity      356      358       +2     
============================================
  Files            39       39              
  Lines          1318     1325       +7     
  Branches        120      120              
============================================
+ Hits           1025     1032       +7     
  Misses          224      224              
  Partials         69       69              
Impacted Files Coverage Δ Complexity Δ
...tgbm/LightGBMBinaryClassificationModelTrainer.java 87.17% <ø> (ø) 23.00 <0.00> (ø)
...feedzai/openml/provider/lightgbm/LightGBMSWIG.java 70.96% <ø> (ø) 11.00 <0.00> (ø)
...openml/provider/lightgbm/LightGBMModelCreator.java 84.00% <100.00%> (+1.64%) 22.00 <4.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4211ddd...5b96411. Read the comment docs.

ptraca commented 4 years ago

LGTM