search

feedzai / feedzai-openml-java

Implementations for Feedzai's OpenML APIs to allow for usage of machine learning models in the Java programming language.
https://www.feedzai.com
Apache License 2.0
2 stars 11 forks source link

ref PULSEDEV-35849 mvn: Update httpclient dependency version #74

Closed ghost closed 2 years ago

ghost commented 2 years ago

So that commons-codec version is also bumped and the bug related to class colision in pulse is fixed.

This change must be cherry-picked to hf-1.0.X, hf-1.1.X, and hf-1.2.X

paulojrp commented 2 years ago

hum so commons-codec is a transitive dependency of httpclient

https://github.com/apache/httpcomponents-client/blob/master/pom.xml#L67

btw is not this PR a replicate of https://github.com/feedzai/feedzai-openml-java/pull/70 and you don't need to create a PR for each hotfix branch, after landing on master you (or someone) can cherry pick that commit to the remaining branches

paulojrp commented 2 years ago

and btw now that we are looking at this repo we should do a similar thing for https://github.com/feedzai/feedzai-openml-java/pull/69

ghost commented 2 years ago

@paulojrp

btw is not this PR a replicate of #70 and you don't need to create a PR for each hotfix branch, after landing on master you (or someone) can cherry pick that commit to the remaining branches

I have performed the cherry picks and then created the PRs so that they could get reviewed. I could cherry pick and immediately do the hf release without being reviewed?

and btw now that we are looking at this repo we should do a similar thing for #69

but all we need to do is accept that PR, correct? Or are you saying we should create a alert for httpclient?

ghost commented 2 years ago

btw is not this PR a replicate of #70

you are right, I am closing this