search

feelpp / book.feelpp.org

:globe_with_meridians: The Feel++ Book
https://docs.feelpp.org
GNU General Public License v3.0
9 stars 30 forks source link

Resolves: 256 update doc of mor thermal building with python #258

Closed lberti closed 1 year ago

lberti commented 1 year ago

Add Python code for the online execution of the thermalbuilding model.

lberti commented 1 year ago

@prudhomm Locally I was not able to check if the notebook is correctly generated. I tested the code blocks, and they run. However, for some reason, the errors don't seem to be correctly computed in this example.

prudhomm commented 1 year ago

Which error type did you used? Do you have the log of the offline code? Have you tried to make it parabolic? Can you plug external temperature from meteo data?

lberti commented 1 year ago

Error type: residual scm Offline code: the error estimation that is displayed during the offline part is of the order 1e-7, and when the fem solution is also computed, the error is of the order 1e-10; it's only in the online part that the error is not properly computed Parabolic: no, it's just the stationary part, as it was implemented in the example thermalbuilding. I needed to document it to check what the model was like. I am working on the parabolic one External temperature: the fifth parameter is the external temperature, involved in the computation of heat fluxes through the walls and the door. I did not add the possibility to read the external temperature from a meteo file.

prudhomm commented 1 year ago

Regarding the last point, i made a remark in the course notes regarding input signals over time at the end. We have to train with dirac signal at initial time. Initial condition are already handled

netlify[bot] commented 1 year ago

Deploy Preview for adoring-edison-f92f3c ready!

Name Link
Latest commit aca27e1ca6897387b7897d810b599dabf9a1c431
Latest deploy log https://app.netlify.com/sites/adoring-edison-f92f3c/deploys/64f59b10df19c2000883bb02
Deploy Preview https://deploy-preview-258--adoring-edison-f92f3c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

prudhomm commented 1 year ago

@lberti here is the page: https://deploy-preview-258--adoring-edison-f92f3c.netlify.app/mor/latest/thermalbuilding/

unfortunately since feelpp cannot be installed on netlify images we cannot check the results of the python code

lberti commented 1 year ago

@prudhomm In any case the Python code needs the developments contained in branch feelpp/2143-clean-mor to run the reduced model with the fpp archive.