feelpp / book.feelpp.org

:globe_with_meridians: The Feel++ Book
https://docs.feelpp.org
GNU General Public License v3.0
9 stars 30 forks source link

263 move data contribution guide #264

Closed lberti closed 1 month ago

lberti commented 1 year ago
netlify[bot] commented 1 year ago

Deploy Preview for book-feelpp-adoring-edison-f92f3c ready!

Name Link
Latest commit c63aae2e05d7908e22577e5479e3876439bcd246
Latest deploy log https://app.netlify.com/sites/book-feelpp-adoring-edison-f92f3c/deploys/6696098f273cba0008c5a66b
Deploy Preview https://deploy-preview-264--book-feelpp-adoring-edison-f92f3c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

prudhomm commented 1 year ago

screenshot

it seems that the new girder partial does not appear on the Data manual. does it ? Perhaps in Data Storage. Also there was a discussion to use feelpp RemoteData to use Girder rather than the Girder API itself directly

Browser metadata ``` Path: /data/ Browser: Chrome 115.0.0.0 on Mac OS 10.15.7 Viewport: 1728 x 904 @2x Language: en-US Cookies: Enabled ``` [Open in BrowserStack](https://www.browserstack.com/user/try-live?url=https%3A%2F%2Fdeploy-preview-264--adoring-edison-f92f3c.netlify.app%2Fdata%2F&os=OS%20X&os_version=Catalina&browser=Chrome&browser_version=115.0&resolution=1728x904&speed=1&start=true&ref=netlify-source)

Open Deploy Preview ยท Mark as Resolved

lberti commented 1 year ago

@prudhomm I have made some modifications in the navigation bar in order to put the pages under Data storage/Girder, and added a section for feelpp_remotedata to the already available documentation including Girder API.

Locally I can see the modifications if I specify the branches to be downloaded in the site.yml file. Maybe you can't see the menu here because of some configuration issue with Netlify?

lberti commented 1 year ago

It also seems that on some push, buildkite jobs are triggered (which causes the red crosses to appear next to the commits)

lberti commented 1 year ago

@prudhomm I can see the modifications locally. I wonder if there is a problem with the specification of branches in site.yml for the Netlify preview, as for example here

or here

There seem to be an analogous problem with this other pull request in feelpp/toolbox that is not able to properly find the partials that come from this PR.

prudhomm commented 12 months ago

I am looking into this, thanks