search

feenkcom / gt4gemstone

A Gtoolkit interface to GemStone
MIT License
8 stars 3 forks source link

Rowanize gtoolkit-gemstone #1

Closed dalehenrich closed 3 years ago

dalehenrich commented 3 years ago

@akgrant43 ... I created the Rowan script to generate the Rowan meta data for gtoolkit-gemstone (rowan/scripts/rowanize.st), however when I tested the install script (rowan/scripts/installGtoolkit-gemstone.topaz), I ran into a couple of problems:

  1. the class SyntaxErrorNotification is not present in GemStone
  2. Pharo's package naming convention and class category naming convention is incompatible with both of Rowan's package naming conventions (Monticello and RowanHybrid). Rowan's Rowan package naming convention would work, but currently Jadeite does not support the Rowan package naming convention yet. In particular, Rowan's Monticello naming convention is based on supporting the original Monticello package naming scheme that allows for adding "extensions" to class categories as seen here and for method categories. However, the two package names: GToolkit-GemStone and GToolkit-GemStone-GemStone are ambiguous package names in the original Monticello scheme and Rowan's Monticello package convention. Rowan's RowanHybrid naming convention can handle the two package names above, but the "hybird" part of the naming scheme is that both class categories and method categories must match the package name. Consequently, I had to edit the source code and change the class categories here and here

Sooo, instead of giving you a script to run, I'm providing you with a pull request with the Rowan meta data and code patches. As menioned earlier, I've included the rowan/rowanize.st script for your viewing pleasure.

I left the GemStone baselines hanging around, but they can be removed at your leisure ...

akgrant43 commented 3 years ago

Hi Dale, Thanks! I knew about SyntaxErrorNotification, it just got lost in my manually copying the code from GemStone to Pharo.