search

feenkcom / gtoolkit

Glamorous Toolkit is the Moldable Development environment. It empowers you to make systems explainable through experiences tailored for each problem.
https://gtoolkit.com
MIT License
1.08k stars 46 forks source link

Zinc log methods are not properly compiled #3473

Open hellerve opened 11 months ago

hellerve commented 11 months ago

Currently, there is an issue with Zinc methods that are not properly compiled, resulting in test failures. The issue is reported at https://github.com/pharo-project/pharo/issues/14846.

Quickfix

An immediate solution is to have 

ZnLogEvent withAllSubclasses collect: #compileAll

during the baseline load.

We added this into the Zinc baseline. The code should be removed when the issues is solved in the Pharo project.

Cheers

girba commented 6 months ago

Should this be closed?

svenvc commented 6 months ago

We do indeed still have a patch in BaselineOfZincHTTPComponentsCore>>#postLoadCore:.

Since we are still on the same Pharo release I don't think anything has changed.

We could try removing the patch to see what happens, but it is a bit cumbersome.