search

feenkcom / gtoolkit

Glamorous Toolkit is the Moldable Development environment. It empowers you to make systems explainable through experiences tailored for each problem.
https://gtoolkit.com
MIT License
1.09k stars 47 forks source link

Renaming an expanded method in a notebook snippet results in notebook pointing to dead method #3857

Closed macta closed 3 months ago

macta commented 3 months ago

If you call a method in a notebook snipped, and expand that method and then use cmd-r on the expanded method, after the rename the notebook method retains the old name and when collapsed its now pointing to something that doesn't exist anymore and so doesn't expand.

While it would be cool for all notebook snippets to be renamed globally (like calling methods do) - I would at least expect the locally expanded version to participate in the rename.

image

In the above you can see a rename about to happen to contentsDecoded - on completion, the originial snippet call will remain contentsDecoded and thus point to nothing

girba commented 3 months ago

Refactorings in code are not (yet) applied to pages. If you refactor the same method in the code from the page, the page code will be renamed properly. So, it's not a bug. It's not yet done.