feincms / django-tree-queries

Adjacency-list trees for Django using recursive common table expressions. Supports PostgreSQL, sqlite, MySQL and MariaDB.
https://django-tree-queries.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
427 stars 27 forks source link

Work around Django bug regarding column alias index numbering for subqueries. #39

Closed sha-red closed 2 years ago

sha-red commented 2 years ago

Apologies for the minimal pull request without any tests and such. Commit early.

matthiask commented 2 years ago

Hi @sha-red

Looks good and makes sense. I'd appreciate a unittest very much, since this area of the code is somewhat hacky.

matthiask commented 2 years ago

Hmm; maybe this is superseeded by #26 and its fix, #42?

sha-red commented 2 years ago

From a quick test with the current version 0.11 this commit indeed seems superseeded.

I'm sorry for the minimal collaboration, I have currently only minimal resources (might hopefully change again in the future.

matthiask commented 2 years ago

Don't worry! All contributions are worthwhile. Thanks for checking again.