feincms / form-designer

A simple form designer for Django
https://form-designer.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
75 stars 32 forks source link

proposal: confirmation mail to sender #29

Closed benzkji closed 2 years ago

benzkji commented 5 years ago

I know this could be done easily, with custom actions. But most of my cutomers request this... One setting, to define the field it's value would become the address to send to. I will implement it anyway, if interested, I can provide a PR.

matthiask commented 5 years ago

I have implemented things like these too in the past. I have used a configurable action with a required field name, where managers have to enter the name of the field containing the email address.

I'm not sure why you'd need a setting for this, or how it would help with email fields' names in e.g. french.

I'd happily review & merge a PR adding another built-in action for something like this, but maybe I'll not be very ... responsive in the next 2-3 weeks.

benzkji commented 5 years ago

good to know. yes, I was mixing up settings and configurable actions...what you write is exactly what I meant!

On 04.10.19 08:48, Matthias Kestenholz wrote:

I have implemented things like these too in the past. I have used a configurable action with a required field name, where managers have to enter the name of the field containing the email address.

I'm not sure why you'd need a setting for this, or how it would help with email fields' names in e.g. french.

I'd happily review & merge a PR adding another built-in action for something like this, but maybe I'll not be very ... responsive in the next 2-3 weeks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/feincms/form_designer/issues/29?email_source=notifications&email_token=AADRH62ZVBQ2VRICLOBEIQTQM3RLLA5CNFSM4I5EHJA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAKUUAQ#issuecomment-538266114, or mute the thread https://github.com/notifications/unsubscribe-auth/AADRH6ZCPHL37CT677FRYMTQM3RLLANCNFSM4I5EHJAQ.

-- bnzk / Ben Stähli -- +41 22 575 25 77 +41 76 425 88 77 Map: https://goo.gl/1AFCCa

benzkji commented 4 years ago

design decision: if a manager clicks "send email" action, it would show the following fields:

the above is one solution - everything in one action.

every one of the three (copy checkbox is not one of the three) fields could be a single action as well...but...then it's again kind of a mess, as the send_email_copy action can be used on it's own, for example - which can be cool, because we can send a copy, and store to db, and not disturb anyone else, if not needed...but, can be harder to understand for non tech savvy users? also, in the action itself, it must be possible to access the other configured (or not configured...) actions (custom sender...). also, it may not be clear, that "custom sender" affects ALL email related actions.....

I would create a PR, but think this needs to be decided beforehand? any preference?

also. compatibility with the currently available default actions is probably important?!

matthiask commented 2 years ago

Please don't overthink things. Step by step. Built-in actions also serve as a documentation for how to achieve more complex things yourself.

The carbon copy field can be added as a non-required field, and if it's filled in that's enough, no need for an additional checkbox. I'd omit the custom sender. You could even extend the existing send_email action with the additional Cc: behavior.

benzkji commented 2 years ago

Thanks. And yes, providing a straight forward solution, serving also as documentation, the way to go. Most people with advanced needs will extend the defaults anyway.