if the field 'title' of FormField is not unique, the data after submiting will not display correctly

feincms / form-designer

A simple form designer for Django

https://form-designer.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

75 stars 32 forks source link

Closed indexofire closed 12 years ago

indexofire commented 13 years ago

if I have two form field with the same title name, the result data in formsubmission will miss partly.

I think add a 'unique=True' into field 'title' will fix it.

matthiask commented 13 years ago

Oops, that's correct.

The proposed fix isn't correct however-- we should instead key the submission values by form field name.

matthiask commented 12 years ago

On second thought I don't think this is correct anymore.

There's a unique_together constraint on ('form', 'name') since the beginning of time :-) which should make this impossible?

Please reopen this issue if you disagree.

Thanks!