tests, showcasing non working defaults for radios/dropdowns

feincms / form-designer

A simple form designer for Django

https://form-designer.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

75 stars 32 forks source link

tests, showcasing non working defaults for radios/dropdowns #34

Closed benzkji closed 3 years ago

benzkji commented 3 years ago

if one removes the " what" from the radio (as value, and as default, and in the assertblock), it will work. At first sight, I dont know why it "doesnt" work.

this PR is a draft, not sure how I would incorporate this and/or refactor the current test suite.

matthiask commented 3 years ago

this PR is a draft, not sure how I would incorporate this and/or refactor the current test suite.

Tests are passing now and you didn't mark the pull request as a draft. Do you want to clean it up or change anything? I don't think anything's missing (except for the CHANGELOG entry but that's fine, really)

benzkji commented 3 years ago

ah, nice thanks. I didnt even know I could have marked is as a draft (in the github UI, right?)...so I just wrote it down ;-). Initial version for sure was a draft, only having failing tests. the solution was obvious, finally. I think it looks good, yes.