search

feivlinus / fork-yeah

Capstone project - Recipe app called Fork yeah!
https://fork-yeah.vercel.app
3 stars 0 forks source link

Feature/navigation #22

Closed vlatkojuric closed 9 months ago

vlatkojuric commented 9 months ago

Added a Navigation that can lead to create new recipes form and a home button which when clicked leads to the home page where the list of recipes is. For now, only on the mobile view when clicked the icon changes a color but later in our Styling user story we will make it also do the same on web.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fork-yeah ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 10:32am
Shahab-Ziaeian commented 9 months ago

Hey @onemanwenttomow thanks a lot for the tips! We made the changes you suggested.

feivlinus commented 9 months ago

Hey Team Fork Yeah!

LGTM! 🙌 🍕

Just a tiny, tiny, tiny suggestion: For some potential future styling of your navigation bar you could consider giving your icons a special color or any styling that shows the user on which page they are on.

Thank you @lennart-kaminsky for your review. Good that you mention that. We have that in mind. We have a special effect for the icons we havent implemented yet. There will be svg filters applied inside the svgs which would switch by calling them with css. We planed to implement that at user story - style. We havent forgot your suggestion :) from before.