feixue94 / imp-release

[CVPR 2023] IMP: iterative matching and pose estimation with transformer-based recurrent module
https://feixue94.github.io/
Other
141 stars 11 forks source link

Error of 'dump_megadepth.py' #5

Closed Uchan1996 closed 1 year ago

Uchan1996 commented 1 year ago

@feixue94 Hi, author. I found an error in the 'dump/dump_megadepth.py'. I ran the code which took about three days, and the code outputed the following error in the line 489. FileNotFoundError: [Errno 2] No such file or directory: 'asserts/mega_nvalid_spp.npy'

I think 'asserts' is a mistake of 'assets', right? Also, what do the lines 486-489 of the code? It seems that it just saves an empty dictionary.

feixue94 commented 1 year ago

yes. you are right - it should be assets and is fixed. In 486-489, we merge the number of valid pairs into a single file for random sampling in the training process

Uchan1996 commented 1 year ago

Thank you for your quick fixing!