search

feiyun0112 / SemanticKernel.Connectors.OnnxRuntimeGenAI

Semantic Kernel connector for ONNX models.
9 stars 4 forks source link

Contribute to Microsoft.SemanticKernel.Connectors.Onnx? #4

Open stephentoub opened 1 month ago

stephentoub commented 1 month ago

Nice job with the library. I've had it on my todo list to augment the https://www.nuget.org/packages/Microsoft.SemanticKernel.Connectors.Onnx library with the ONNX runtime GenAI support, sat down to implement it, and stumbled across your implementation. I can still do so, but would you instead just like to contribute your implementation there in order to centralize our efforts?

cc: @matthewbolanos, @markwallace-microsoft

feiyun0112 commented 1 month ago

Nice job with the library. I've had it on my todo list to augment the https://www.nuget.org/packages/Microsoft.SemanticKernel.Connectors.Onnx library with the ONNX runtime GenAI support, sat down to implement it, and stumbled across your implementation. I can still do so, but would you instead just like to contribute your implementation there in order to centralize our efforts?

cc: @matthewbolanos, @markwallace-microsoft

@stephentoub I have pull codes to https://github.com/microsoft/semantic-kernel/pull/6518

elbruno commented 3 weeks ago

This is so cool!

I added support to Vision scenarios (while writing samples for Phi-3 https://github.com/elbruno/phi3-labs/tree/main/src/SemanticKernel.Connectors.OnnxRuntimeGenAI)

Do you want me to create a PR and you can have them here? or should we wait for the SK merge?

Best

PS: your library is so cool!

feiyun0112 commented 3 weeks ago

This is so cool!

I added support to Vision scenarios (while writing samples for Phi-3 https://github.com/elbruno/phi3-labs/tree/main/src/SemanticKernel.Connectors.OnnxRuntimeGenAI)

Do you want me to create a PR and you can have them here? or should we wait for the SK merge?

Best

PS: your library is so cool!

you can contribute to SK, this project will be frozen