search

felHR85 / UsbSerial

Usb serial controller for Android
MIT License
1.78k stars 581 forks source link

NPE at FTDISerialDevice.getBcdDevice() #352

Open dx-codebreaker opened 2 years ago

dx-codebreaker commented 2 years ago

Fatal Exception: java.lang.NullPointerException Attempt to read from null array com.felhr.usbserial.FTDISerialDevice.getBcdDevice (FTDISerialDevice.java:789) com.felhr.usbserial.FTDISerialDevice.encodedBaudRate (FTDISerialDevice.java:828) com.felhr.usbserial.FTDISerialDevice.setBaudRate (FTDISerialDevice.java:197)

It seems like an NPE check can be added to descriptors object to fix the issue. https://github.com/felHR85/UsbSerial/blob/master/usbserial/src/main/java/com/felhr/usbserial/FTDISerialDevice.java#L789

byte[] descriptors = connection.getRawDescriptors(); return (short) ((descriptors[13] << 8) + descriptors[12]);