felangel / bloc.js

A predictable state management library that helps implement the BLoC design pattern in JavaScript
https://bloclibrary.dev
190 stars 22 forks source link

package.json for react-bloc package has the wrong typings path #21

Closed prateek14 closed 4 years ago

prateek14 commented 4 years ago

package.json for react-bloc package has the wrong typings path

https://github.com/felangel/bloc.js/blob/master/packages/react-bloc/package.json Ln 16 "typings": "dist/types/react-bloc.d.ts", should be "typings": "dist/types/lib/react-bloc.d.ts",

felangel commented 4 years ago

Hi @prateek14 👋 Thanks for opening an issue!

What makes you say the typings path is wrong? I took a look and it seems the current typings location is correct (at least from what I can tell).

Screen Shot 2020-09-03 at 11 00 00 AM

dist/types/react-bloc.d.ts looks correct. Let me know what you think?

felangel commented 4 years ago

Closing for now but feel free to comment with additional information and I'm happy to continue the conversation 👍

prateek14 commented 4 years ago

Thanks for the quick reply. It looks like yarn had installed v0.1.0, issue is fixed on the latest version.