fix: Unreachable case (states) in Actions Widget of flutter_timer example

dk-a-dev commented 1 year ago

Description

While re-building the flutter_timer app , I have encountered a bug in the Actions widget.
In the switch case statements, only the TimerInitial class is reachable, all the other classes are unreachable.
Hence it affects the UI, and none of the other defined actions occurs making other parts dead(code)

Warning(in vs code): This case is covered by the previous cases. Try removing the case clause, or restructuring the preceding patterns.

Steps To Reproduce

Run/Debug the flutter_timer app
See the bug

Expected Behavior

Timer app changing UI with all the action states

Screenshots and Screen recordings

https://github.com/felangel/bloc/assets/84137299/2f88f48b-3837-43fa-8cab-7d0bdf5b0175

Note

Can you please assign this issue to ME

marcossevilla commented 1 year ago

hey @dk-a-dev! do you have a PR open to fix this already?

dk-a-dev commented 1 year ago

Not Yet @marcossevilla

marcossevilla commented 1 year ago

@dk-a-dev cool, I'll assign it to you and then you can reference this issue when you open the PR 👍

dk-a-dev commented 1 year ago

I cloned the repo and tried to re-produce the warning but there is no problem with the existing code base as my vscode does not give any warnings. In my rewrite, I separated the widgets, but that definitely should not hamper the linter for warnings. Maybe the varied version of the linter could be a reason for those warnings. I am sorry for opening an issue without proper checks @marcossevilla you can close the issue

felangel / bloc